search

x-tag / core

The Heart of X-Tag
http://x-tag.github.io/
Other
1.25k stars 151 forks source link

Cross browser prefix detection #173

Closed joao-arvins closed 6 years ago

joao-arvins commented 7 years ago

Updated logic to set prefix so that it works in all browsers.

joao-arvins commented 7 years ago

Fix for:

joao-arvins commented 7 years ago

@csuwildcat all the checks are now collapsed into a single regexp. Can you have a look when you have some time please?

Thanks

joao-arvins commented 7 years ago

Hi @csuwildcat . Did you had the opportunity to have a look at this pull request?

Cheers

csuwildcat commented 7 years ago

I did - I had that one last question before merging. Can you take a look and answer for me?

joao-arvins commented 7 years ago

Not sure about the question you're talking about. Is it the one about collapse all the checks into one single regexp? If so I've already updated it some weeks ago. Check the latest commit.

If not can you point me to the right direction?

Thanks

toreholmberg commented 6 years ago

Did this make it into the build?