search

x-tag / core

The Heart of X-Tag
http://x-tag.github.io/
Other
1.25k stars 151 forks source link

TS type definitions #174

Open Istar-Eldritch opened 7 years ago

Istar-Eldritch commented 7 years ago

I would like to add the typescript type definitions to x-tag and I was wondering if you would accept a PR in this repo or if I would have to create them in DefinitelyTyped.

They clearly state that if possible the definitions should live with the original code:

If you are the library author, or can make a pull request to the library, bundle types instead of publishing to DefinitelyTyped.

So, would you accept a PR here? Also let me know if you need more context of why this is useful.

joao-arvins commented 7 years ago

+1 for the typescript type definitions