search

x-tag / core

The Heart of X-Tag
http://x-tag.github.io/
Other
1.25k stars 151 forks source link

enhancement question #184

Closed ghost closed 6 years ago

ghost commented 6 years ago

-EDIT ( For V2)

  var regexParseExt = /([\w+\-]+)|(::|:)(\w+)(?:\((.+?(?=\)))\))?/g;

From

 var regexParseExt = /(\w+)|(::|:)(\w+)(?:\((.+?(?=\)))\))?/g;

I was thinking that you maybe able to use this to capture dashes in prop names @csuwildcat, do you think this would work?

ghost commented 6 years ago

I really haven't tested this inside xtag but I use similar to capture the \w and - symbols using reg exp for Pi Reel.

csuwildcat commented 6 years ago

What do you want to do with this addition?

ghost commented 6 years ago

just allow dash property names to be detected. Just a different option to have, you could also re-use the regexp with in the library to fit other cases. I have it on a build going on now and it doesn't cause any problems with normal operations of xtags.

ghost commented 6 years ago

Personally I'll problem re-use it for some personal projects on my own build.