search

x-team / vacation-status-update

Slack integration helping to communicate your vacation time off to team members
MIT License
11 stars 7 forks source link

Updated question message for clarity. #118

Closed rmariuzzo closed 6 years ago

rmariuzzo commented 6 years ago

Fixes #117.

ryanchartrand commented 6 years ago

@rmariuzzo Thanks for helping out! One thing we have to do here is get our language crystal clear. The bot asks "What day will you be back?" when collecting endDate, which means if we are reporting "and your last day of vacation will be..." then it would be endDate - 1 :)

Let's update the text to instead be more accurate:

your first day of vacation will be {{vars.startDate.fancy}} and you will return on {{vars.endDate.fancy}}

rmariuzzo commented 6 years ago

@ryanchartrand I was a little bit naive and blind as I thought it was just a simple text replacement. And it is a text replacement, however I should have spend a few seconds analyzing the sense of it.

I have updated this PR with the changes requested.

ryanchartrand commented 6 years ago

Looks great! @jacekelgda can you review?

jacekelgda commented 6 years ago

Looks good +1