search

x-team / x-map

MIT License
8 stars 3 forks source link

Fixes #157, #156 #174

Closed jedrzej closed 8 years ago

jedrzej commented 8 years ago

Fixes #157 Remove @ from slack ID Fixes #156 Show @ next to slack ID in profile page

This change is Reviewable

bernardodiasc commented 8 years ago

looks good! just let a question about something that look a typo in the input placeholder.

jedrzej commented 8 years ago

Good catch, I'll fix and merge.

jedrzej commented 8 years ago

Reviewed 2 of 3 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

jedrzej commented 8 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

jedrzej commented 8 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion.

_client/js/components/forms/ProfileForm.js, line 50 [r1] (raw file):_

Previously, bernardodiasc (Bernardo Dias) wrote… > why `Slack ID2` in the palceholder?

Done.

Comments from Reviewable

jedrzej commented 8 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

jedrzej commented 8 years ago

Reviewed 1 of 3 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

bernardodiasc commented 8 years ago

Reviewed 2 of 3 files at r1, 1 of 1 files at r2. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable