Fancy background, added missing deps

x-team / x-map

MIT License

8 stars 3 forks source link

Fancy background, added missing deps #176

Closed peterKaleta closed 8 years ago

peterKaleta commented 8 years ago

changed img url loaders from inline to config implicit
added missing deps required for frontend testing
reducer no longer assumes that user is logged in by default (isLoggedIn was set to true in the initial state)
fancy background added + micro styling changes
map will be hidden if user is not logged in

vid

This change is

bernardodiasc commented 8 years ago

this is really good 👍

jedrzej commented 8 years ago

Reviewed 13 of 13 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

client/js/components/fragments/Loader.js, line 19 [r1] (raw file):

      <div className="loader-container">
        <video className="loader-bg" loop autoPlay>
          <source src="../../../videos/bg-video.mp4" type="video/mp4"/>

Could that asset be imported and used the same way we import all other assets?

Comments from Reviewable

peterKaleta commented 8 years ago

client/js/components/fragments/Loader.js, line 19 [r1] (raw file):

Previously, jedrzej wrote…

> Could that asset be imported and used the same way we import all other assets?

sadly importing mp4 through file and url loaders blows tests. I had to hack it through html-loader.

Comments from Reviewable