x0a / uBO-YouTube

Easier way to exempt your favorite YouTube channels from adblocking.
GNU General Public License v3.0
124 stars 8 forks source link

Black screen on all whitelisted ads #48

Open filippesic opened 1 year ago

filippesic commented 1 year ago

Hi,

I'm not sure if this is a bug, but it sure wasn't working like this a month ago. Every ad is just a black screen and even tho some ads are interesting I cannot click or visit the site for that ad.

Cheers

Firefox 112.0.1 Windows 10 latest update Identical issue on Macbook Air M1 with same Firefox version, latest MacOS

Screenshot (8)

Screenshot (7)

Steve3854 commented 1 year ago

I just discovered this extension and am having the same issue. Also can't click through to the advertiser. Would be fine, but my only concern is I'm not sure if youtube channels get anything if the ad is unlickable and without video.

filippesic commented 1 year ago

I just discovered this extension and am having the same issue. Also can't click through to the advertiser. Would be fine, but my only concern is I'm not sure if youtube channels get anything if the ad is unlickable and without video.

Exactly what I was thinking 🙂

x0a commented 1 year ago

Hey,

Thank you for the report. I've reproduced and confirmed the issue. Working on this now and should have an update by the end of the week.

Thanks

x0a commented 1 year ago

So turns out the issue is caused by the youtube##.ad-showing > .html5-video-container rule in EasyList, setting the .html5-video-container display property to none when ads are playing. Since this is an injected content script (vs the injected userscripts that this extension uses), it's difficult to override without also using a content script, which I will eventually do.

But in the meantime, this extension re-implements all adblocking by uBO's default lists, so its possible to disable uBO altogether on YouTube, this extension will still block/remove ads as it detects them.

I'll have a new release addressing the issue within the week.

Thanks