search

x0a / uBO-YouTube

Easier way to exempt your favorite YouTube channels from adblocking.
GNU General Public License v3.0
124 stars 8 forks source link

Restyling settings page #6

Open matteioo opened 4 years ago

matteioo commented 4 years ago

According to my last opened issue #5 I wanted to give the input of restyling the settings page. As you are currently using Bootstrap but using Googles Material design for UI consistency regarding the ADS button wouldn't it be more resource efficient using the Material Design CSS Framework also for other design settings.

If you are using a CDN for getting the files of the Frameworks the argument with resource efficiency wouldn't be that important.

matteioo commented 4 years ago

I am willing to think of this (may take some time as other things may get in between). The work itself would probably take some time too but I could provide input this way by creating a detailed "wireframe" in probably Adobe XD and afterwards share a visitors link for you to inspect it... Cannot guarantee anything!

x0a commented 4 years ago

I think switching to Material makes sense and would make a good longer term project, since it requires a bit of investment on my end to actually learn Material and effectively use the classes it provides

With the current setup, I leveraged a bunch of bootstrap classes to make it so that they have a different layout and color, but they are actually the same page. This makes it so that I can easily enable functionality that's available in the 'Settings' page in the popup as well, since all the code is the same, I could just add the styling. I would like to keep this setup if I switch to material, since it's a little easier to maintain.

But if you have design proposals, I can do that a lot faster. Would definitely appreciate a wireframe so I have a rough idea. By the way, I think our users would appreciate if we didn't deviate too far from uBlock Origin's design philosophy. Minimalistic and not too "flashy". Group things into tabs so we don't clutter the page, just like uBlock.