Closed okigan closed 10 years ago
@okigan the tests are failing though: https://drone.io/github.com/okigan/simpleauth/latest
@erichiggins thanks so much for reviewing!
oh boy, how do I setup gae environment in IntelliJ 13?
Bump
@crhym3 @erichiggins pull request ready for merge, please proceed
@okigan It looks like there are still a few outstanding comments in the PR that you may need to address before merging.
@crhym3 Are you going to take over the review from here?
@erichiggins i don't see any required to fix, only comment/suggestions for future.
@erichiggins I don't want to take over, but I guess I could in case you don't have cycles.
PS sorry for slow responses. It's been crazy these days.
Sorry, I just realized I was reviewing with the wrong browser window/account.
@okigan That's about all of the review comments I have for now. Once you address those, I'll take another pass.
@erichiggins ok, go for "another pass"
This seems fine to me by @crhym3 should give the final review/approval.
@crhym3 bump
@okigan sorry, I was on a short vacation. Will be back tomorrow or Wed, but I've already pulled your changes. Just wanted to make sure all tests pass.
@crhym3 no problem (in fact, get some rest!), just wanted to make sure we are still on track
First pass complete.