search

x2002uwh / moodle2-skillsoft-activity

Automatically exported from code.google.com/p/moodle2-skillsoft-activity
0 stars 0 forks source link

SetType calls missing in mod_form #4

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Hi Martin, 

hope you're keeping well - just looking through your latest Moodle 2 code and 
noticed a few things... so adding details here.

mod_form.php should use setType for all fields - the hidden fields at the 
bottom of the form have no type set so will default to using PARAM_RAW which 
isn't great.
timemodified, timecreated, completable should have their types set using 
$mform->setType

thanks!

Original issue reported on code.google.com by Dan.Mars...@gmail.com on 19 Jun 2013 at 8:05

GoogleCodeExporter commented 8 years ago 
Fixed
http://code.google.com/p/moodle2-skillsoft-activity/source/detail?r=105

Original comment by martinho...@googlemail.com on 19 Jun 2013 at 8:28

GoogleCodeExporter commented 8 years ago 
wow - that was really quick! - thanks heaps!

Original comment by Dan.Mars...@gmail.com on 19 Jun 2013 at 8:52