Mailfixes

[markrickert]

Fix some mail related issues and implements a demo in the demo project for using the SimpleMailShare class.

[x2on]

What are the fixes?

[markrickert]

Mostly just adding the mail demo to the demo project. It demonstrates that you need to hold onto the mail composer variable because if you run:

SimpleMailShare *simpleMailShare = [[SimpleMailShare alloc] init];
if ([simpleTwitterShare canSendMail]) {
    [simpleMailShare shareText:@"" subject:@"" isHTML:NO];
}

You get a crash because the memory is released after the modal view is shown and then when you go to dismiss it, the delegate is nil.

You can look at my commits and see what I did.

[x2on]

Ok thanks for that hint. I would only merge this if you cleanup the code and remove the other code. If you won't do that i can fix that.

[markrickert]

I'm not sure what you mean buy "remove the other code". This is a clean pull request.

[x2on]

There is many other stuff in this pull request...

There are changes in AppDelegate.m and SimpleMailShare.h and SimpleMailShare.m there is a new property instead of an ivar.

Also the different nibs for iPad and iPhone were merged in your commits.

If you remove that from your pull request i can merge this...

[markrickert]

Right - that was on purpose... there's absolutely no need to have two xib file in the code when they can autoscale on the correct sizes based on the device screen. We're talking about 3 buttons here, and the code works great on both iPhone and iPad screen sizes.

[markrickert]

I think you'll find that it works beautifully with one less file in the project with my changes.

[x2on]

At this moment were are talking about 3 buttons, but im working on some different features + layout for iPad and iPhone (more sharing options...)

And what about the property? I don't see that this change is needed... And the getRootViewController is also not needed.

[markrickert]

Wahtever.

[x2on]

I added the changes without that stuff.