search

x3042 / ExactODEReduction.jl

Exact reduction of ODE models via linear transformations
MIT License
13 stars 3 forks source link

Separate types conversion from main logic #3

Closed sumiya11 closed 1 year ago

pogudingleb commented 3 years ago

What does this mean?

sumiya11 commented 2 years ago

@pogudingleb We want to elude multiplie single element type conversions during high loaded computations, such as convert in

https://github.com/x3042/Exact-reduction-of-ODE-systems/blob/e5c2f50b361395a06d0dc3edcc336111cf2d71cc/src/structs/sparsik.jl#L316 or coercing into field in https://github.com/x3042/Exact-reduction-of-ODE-systems/blob/e5c2f50b361395a06d0dc3edcc336111cf2d71cc/src/gizmos.jl#L60

What could be optimal here is to perform vectorized type conversion for each element first, and the rest of the computations on it after

pogudingleb commented 2 years ago

This makes sense but is this really a bottleneck?

sumiya11 commented 1 year ago

closed as being outdated after the last refactor