Capstone Feedback - Githubissues

x3419 / TriageAllTheThings

Another DFIR triage tool

1 stars 0 forks source link

Capstone Feedback #5

Open NaturalFractals opened 6 years ago

NaturalFractals commented 6 years ago

Abstract

"This project is aiming to solve that problem, by providing an interface that can automate the process of deploying various tools dynamically, without providing extra programming. "

In this sentence here you switch tenses. I think it should be "This project was aimed". Not 100% on this though.

"Though this project has application beyond digital forensics"

has an application, or has applications.

Introduction

"RAM and "

Although most everyone knows what this is you may want to spell the acronym out the first time to be safe.

Features Summary

I would suggest breaking the text into paragraphs if possible to make it easier to read.

"The configuration file, formatted in Tom's Obvious Minimal Language [5] for more information)"

There is a closing bracket here, but no opening bracket.

NaturalFractals commented 6 years ago

Design Development and Test

"Small in size"

I assume you mean file or package size here, but I think it might be more clear to clarify.

" All that this this library was used for was to serialize the text file into an object that can then be used like any other struct in golang."

have an extra "this" in the sentence at the beginning.
Nice UML diagram!

Test

Under the GUI section "Unfortunately most of the testing that I intended to implement for the ProtonMail/ui framework did get integrated. "

I think Unfortunately needs a comma after it

Under the UI

"Furthermore, through the usability testing (simply messing around with the GUI trying to break things), the results have been very consistent and indicate a stable build."

I think you meant throughout instead of through here? Also, I am not sure you need the common after usability testing.

NaturalFractals commented 6 years ago

Nice feature table!

Conclusion

"Avoiding this problem is important, because I consider myself very passionate about cyber security and stopping criminals from stealing intellectual property - if this project can assist in the investigation of a single criminal, then that is something that I can truly be proud of."

I don't know much about grammar, but I think a period here would work just as well as the -. I am not sure if it matters?
I notice a lot of - in the report. In most places I think a period works as well. You may want to ask someone who is better at writing than I if that is appropriate.

Overall looks great!