search

x3dom / apps-modeling

Publicly Available Applications
Other
3 stars 3 forks source link

[ComponentEditor] Nozzle only has 4 parameters #104

Closed tpaviot closed 10 years ago

tpaviot commented 10 years ago

In the current nozzle primitive implementation, it's not possible to modify inner radius. There should be 5 parameters for the nozzle, it misses RInside. Furthermore, the two height parameters seems to not be independant. What part of the spec did u use?

tsturm commented 10 years ago

To find the right part of the spec was a little hard. In the end we used our own interpretation of the spec: "PDMS DESIGN Reference Manual Part3: Elements and Attributes 5-8"

I've added RInside and make the two height parameters independent. Hope the implementation is now correct.

tpaviot commented 10 years ago

I can't see any difference in the component editor interface. Did I miss something?

tsturm commented 10 years ago

Can you try it again?

tpaviot commented 10 years ago

I can see the 5 parameters, but 3 of them (Height, RInside and ROutside) does not have any impact, i.e. modifying those parameters don't change the shape.

yjung commented 10 years ago

@tsturm and @tpaviot : fixed?

tpaviot commented 10 years ago

@yjung no.

yjung commented 10 years ago

@tsturm Could you please check and fix?

yjung commented 10 years ago

Just added some constraints, works now.