search

x3dom / apps-modeling

Publicly Available Applications
Other
3 stars 3 forks source link

x3dom.Moveable does not work with MatrixTransform for Primitive #58

Closed mlimper closed 11 years ago

mlimper commented 11 years ago

@yjung Could you please take a brief look at this? The corresponding line is line 46 in PrimitiveManager.js - thanks! :-)

mlimper commented 11 years ago

... in combination with the callback starting with line 394 - seems it is not invoked? I have changed line 402 and the following few statements, in order to update the stored translation values for the primitive as well as the UI... do you think it acceptable like this, and does it fix the issue in Safari?

yjung commented 11 years ago

Fixed with commit ba036e185c491933862a4e96001d037ec0534160 (@mlimper: please see diff for reasons, I added also lots of TODOs due to the unfinished code modifications, please have a look). The code changes concerning line 402 ff. unfortunately don't fix the Safari performance issues, to my mind it has something to do with jQuery UI update behavior.

mlimper commented 11 years ago

Thanks - I'm aware of unfinished parts, for instance concerning the IDMap as well as the access to the primitive list. To increase transparency, the primitive has now an own class, where everybody can look up the members in the class definition. IDMap etc. are not any more members of a DOM Transform node, and now everything related to a primitive should be queried by primitiveList[id].get...(), or by primitiveManager.getPrimitiveByID(..).get...(). The old accessors have been removed in commit d4444073b5e5f2b676b502353e042a6df0ead7dd. Two of the three accessor functions were currently unused anyway, the third one was only used by the snapping code and has been replaced where it was used.

I'll now continue to adapt the code inside the primitive manager, following your TODOs.