search

x3dom / apps-modeling

Publicly Available Applications
Other
3 stars 3 forks source link

Snapping code in component_editor outdated #95

Open yjung opened 10 years ago

yjung commented 10 years ago

Completely remove primitive snapping or update to plant_editor version? In this regard, sharing common js files (cp. issue #90) between editors would be better to avoid such problems.

mlimper commented 10 years ago

Primitive snapping is maybe not that important as component snapping, so IMHO we could remove the primitive snapping from the component_editor

yjung commented 10 years ago

Ok, removing the whole code here is also an option.

mlimper commented 10 years ago

If you agree... I think the users we are targeting don't wanted the automatic snapping tool anyway, and the "manual" snapping tool (picking list entries) just makes sense in the plant editor.. so if you agree, let's just remove the primitive snapping for now

yjung commented 10 years ago

Yes, I agree... What about @tpaviot?

tpaviot commented 10 years ago

Primitive snapping is actually something important (the PDMS "Psets" allow doing this). But I agree it's not that important for the coming demo. Component snapping, in the plant editor, is much more important. I'm ok for a temporary removal of primitive snapping, but it's something we have to keep in mind for the future. In the meantime, it should however be possible to rotate the primitives to ensure they're correctly placed (currently, AFAIK, only primitive translation is possible).

yjung commented 10 years ago

There is also scale and rotation, you have switch the mode via the corresponding buttons in the top menu bar (though only via UI, same fields then as for translation).

tpaviot commented 10 years ago

Thanks, I didn't notice this feature. I was confused by the fact that the parameters keep the same name X,Y and Z whether the selected mode is enabled. Other note: when switching to scale/rotate mode, any mouse move switches to translate mode.

yjung commented 10 years ago

For mouse interaction, currently only translation is implemented, therefore this doesn't switch here...