search

x3dom / x3dom

X3DOM. A framework for integrating and manipulating X3D scenes as HTML5/DOM elements.
http://x3dom.org
Other
815 stars 271 forks source link

Remove duplicate codes #1198

Closed microaaron closed 2 years ago

microaaron commented 2 years ago

versions[ "AMMO" ] contains versions[ "PHYSICS" ]. That makes most codes duplicated.

andreasplesch commented 2 years ago

Good catch. Could you please confirm that you tested the new build, and add a line to CHANGELOG.md for this PR? Thanks.

microaaron commented 2 years ago

I don't know how to test the new build, but it seems to work well.

andreasplesch commented 2 years ago

Thanks. Please try one of the Physics examples at https://www.x3dom.org/examples/, for example

https://examples.x3dom.org/physics/motorJoint.html

with the new build.

As a note, it appears the reason why AMMO contained PHYSICS was due to the incremental concatenating which seems complicated.

microaaron commented 2 years ago

examples with new x3dom-physics.debug.js General example Ball joint pendulum Motor Joint Inline Scene Physics Single Axis Hinge Joint

examples with new x3dom-physics.js General example Ball joint pendulum Motor Joint Inline Scene Physics Single Axis Hinge Joint

andreasplesch commented 2 years ago

Perfect.