x3dom / x3dom

X3DOM. A framework for integrating and manipulating X3D scenes as HTML5/DOM elements.
http://x3dom.org
Other
815 stars 271 forks source link

Check if findX3DDoc() succeeds #1201

Closed eamanola closed 2 years ago

eamanola commented 2 years ago

regarding issue:

https://github.com/x3dom/x3dom/issues/1200

Summary: sometimes this._nameSpace is null

Changes: Check if _nameSpace exists, and that doc is found, before proceeding, so the script wont crash

andreasplesch commented 2 years ago

This looks good. Could you please check tests in the test folder which do dom node removal ?

https://github.com/eamanola/x3dom/blob/master/test/functional/memory.html : works fine

https://github.com/eamanola/x3dom/blob/master/test/functional/runtime.html :

https://github.com/eamanola/x3dom/tree/master/test/regression-suite/test/cases/changeShaderAndDOM :

https://github.com/eamanola/x3dom/blob/master/test/regression-suite/test/cases/reload/reload.html :

You can use githack like this:

https://raw.githack.com/eamanola/x3dom/master/test/functional/memory.html

eamanola commented 2 years ago

Tests seem to run ok, at least no error messages. Should I pay attention to something in particular.

They all give this on load, but probably irrelevant:

XML Parsing Error: syntax error

Location: https://raw.githack.com/eamanola/x3dom/master/test/regression-suite/test/build/core/packages.json

Line Number 1, Column 1:
andreasplesch commented 2 years ago

Thanks. Could you please add an entry to CHANGELOG.md ?

eamanola commented 2 years ago

sure thing.

andreasplesch commented 2 years ago

Thanks.