Closed eamanola closed 2 years ago
This looks good. Could you please check tests in the test folder which do dom node removal ?
https://github.com/eamanola/x3dom/blob/master/test/functional/memory.html : works fine
https://github.com/eamanola/x3dom/blob/master/test/functional/runtime.html :
https://github.com/eamanola/x3dom/tree/master/test/regression-suite/test/cases/changeShaderAndDOM :
https://github.com/eamanola/x3dom/blob/master/test/regression-suite/test/cases/reload/reload.html :
You can use githack like this:
https://raw.githack.com/eamanola/x3dom/master/test/functional/memory.html
Tests seem to run ok, at least no error messages. Should I pay attention to something in particular.
They all give this on load, but probably irrelevant:
XML Parsing Error: syntax error
Location: https://raw.githack.com/eamanola/x3dom/master/test/regression-suite/test/build/core/packages.json
Line Number 1, Column 1:
Thanks. Could you please add an entry to CHANGELOG.md ?
sure thing.
Thanks.
regarding issue:
https://github.com/x3dom/x3dom/issues/1200
Summary: sometimes
this._nameSpace
isnull
Changes: Check if
_nameSpace
exists, and thatdoc
is found, before proceeding, so the script wont crash