search

x3omdax / PenBox

PenBox - A Penetration Testing Framework - The Tool With All The Tools , The Hacker's Repo
https://www.facebook.com/CEH.TN
Other
464 stars 195 forks source link

Adding shebang & code refactoring #1

Closed elacheche closed 8 years ago

elacheche commented 8 years ago

You should always add a shebang! In this case you should add the shebang of python2.7

I can know it's python 2.7 from the the first "print" I see :)

Also, you have too many prints in there! You should refactor that! It'll affect the execution time. → Not only the prints anything else that you used like you did with prints!

I think that it's not a good thing to adopt the "one file" strategy, as it will have too many lines and it will affect the maintenance of the code.

Other PQ are coming..

x3omdax commented 8 years ago

this is only a beta version of the tool , many and many improuvements will occur , thank you very much