search

x3p0-dev / x3p0-ideas

A new WordPress theme.
GNU General Public License v3.0
43 stars 4 forks source link

[Query Pagination] Move all instances to a pattern #1

Open justintadlock opened 5 months ago

justintadlock commented 5 months ago

The goal is to move any instance of the Query Pagination block to a pattern. This allows us to manage the pagination output from a single file. This is a very good thing for long-term maintenance (fewer potential bugs and no inconsistencies across usages). It would also make it more easily swappable with alternate pagination patterns on the templating side (swapping shouldn't be an issue in the editor).

Currently, pagination patterns are broken in WordPress. With the following fix, they can be included, but they do not use the correct /page/* links on inherited queries:

Related issues:

carolinan commented 2 months ago

This seems to have been fixed "somewhere in Gutenberg 18.x" if you don't mind testing it again.

justintadlock commented 1 month ago

@carolinan - This is still giving me the ?query-page=2 URLs on Gutenberg 18.3.