[Code] Remove `<br>` fix

x3p0-dev / x3p0-ideas

A new WordPress theme.

GNU General Public License v3.0

43 stars 4 forks source link

[Code] Remove `<br>` fix #2

Closed justintadlock closed 4 months ago

justintadlock commented 4 months ago

Gutenberg is adding extra <br> characters in. We can remove the replacement of those in src/Tools/CodeBlockHighlight.php when this ticket is fixed:

https://github.com/WordPress/gutenberg/issues/58659

justintadlock commented 4 months ago

After investigation, it seems that is an issue with the Prism.js library in use not respecting valid HTML.

More info here: https://github.com/WordPress/gutenberg/issues/59548#issuecomment-1980983287

For this reason, I'm closing this because the fix is on our end and not Core. The existing fix needs to remain to ensure Prism is properly handling markup.