x3ro / redmine_amazon_s3

This Redmine plugin stores file attachments on Amazon S3 instead of the local filesystem.
https://x3ro.github.io/redmine_amazon_s3/
MIT License
8 stars 11 forks source link

Patched Attachment to use the proper disk_filename_s3. #12

Open thorsten-de opened 7 years ago

thorsten-de commented 7 years ago

Sorry I really just wanted to push a PR to my own fork. That said, I patched Attachment#diskfile to return the proper S3 url and Attachment#readable? to return true if the file exists on S3.

Then, and that relates to PDF rendering, I patched the PDF renderer to use open_uri, for the former implementation was not able to get our images porperly.