x42 / fil4.lv2

4 Band Parametric EQ
http://x42-plugins.com/x42/x42-eq
GNU General Public License v2.0
79 stars 14 forks source link

Feature Request: Piano Roll below the frequency scale #12

Closed MrBollie closed 5 years ago

MrBollie commented 5 years ago

Hey there! :)

It would be nice to have a piano roll below the frequency scale and tinting the aproximate keys corresponding to the set band frequency accordingly.

This would be very convenient if you communicate in more musical terms. Like, "Whenever I hit my low E on my Bass, I have this resonant frequency." ;)

Cheers Bollie

x42 commented 5 years ago

Nice idea! I've started some experiments. Perhaps an annotation "Note +/- cent" is more useful.

A piano-roll is kinda hard to read and I don't yet know where to draw it.

The screenshot piano-roll below shows MIDI notes 21..128). It looks kinda odd to cut it off at 12.5kHz (note 127). Also Pianos don't even go that high.

Screenshot at 2019-08-15 03-42-08

x42 commented 5 years ago

Perhaps showing "Note Octave cents" below the frequency dial at the bottom or as tooltip on the knob, is most useful.

What do you think?

x42 commented 5 years ago

4fd4cb175 now looks like

Screenshot at 2019-08-15 06-25-08

nettings commented 5 years ago

If you go with the piano (not "roll", just the keyboard) metaphor, then don't extend it to the entire spectrum, just from A,, to a´´´´, so that it actually provides some "recognition factor" for musicians. I like it.

x42 commented 5 years ago

Good idea. That indeed increases readability. Notes outside the A0..C8 range are now shaded:

Screenshot at 2019-08-15 16-08-42

x42 commented 5 years ago

Feature complete as of v0.6.6-10 8770e99

Now with snap + drag support of the indicators on the piano[roll], and configurable tuning (scroll-wheel on the "A:440" indicator left of the piano).

Please test.

thenktor commented 3 years ago

Would be nice to make the piano roll optional ;-)