search

x42 / robtk

robin's LV2 UI ToolKit
GNU General Public License v2.0
15 stars 8 forks source link

Fix robtk.mk dependency on PLUGIN_SOURCE #2

Open domohawk opened 9 years ago

domohawk commented 9 years ago

The UI targets in robtk.mk should include a dependency on PLUGIN_SOURCE, so that if it is modified, the makefile will rebuild.

I've tried adding variants such as gui/$(*F).c, $(value $(*F)_UISRC) and gui/%.c to L27 but I can't get the makefile fu right. hardcoding the filename (e.g. gui/rtkfil.c) works however.

x42 commented 9 years ago

After include $(RW)robtk.mk just add add a single line for extra dependencies. e.g.

$(BUILDDIR)$(GUI_NAME)$(LIB_EXT): gui/rtkfil.c

to declare additional dependencies. example: https://github.com/x42/meters.lv2/blob/master/Makefile#L444

domohawk commented 9 years ago

Yea I know it can be modified after checkout, however since robtk does depend on this file via the #include, it should be reflected in the makefile deps, not only for when it changes but if it is missing it gives a better error.

I just hardcoded it in mine, but the file can be named anything, so for the robtk.mk it should use the rule/var somehow, but I could not find the make-su to get it to work. On Mar 28, 2015 11:52 PM, "robin" notifications@github.com wrote:

After include $(RW)robtk.mk just add add a single line for extra dependencies. e.g.

$(BUILDDIR)$(GUI_NAME)$(LIB_EXT): gui/rtkfil.c

to declare additional dependencies. example: https://github.com/x42/meters.lv2/blob/master/Makefile#L444

— Reply to this email directly or view it on GitHub https://github.com/x42/robtk/issues/2#issuecomment-87240399.