Segfault on Debian 9 testing/stretchy

[hairmare]

As i mentioned in https://github.com/x42/silan/issues/3#issuecomment-279985845 Debian testing is currently exhibiting segfaults.

This can be reproduced using the following steps on a new nightly netinst iso install:

apt-get update
apt-get install silan

curl -o /tmp/incorrect.mp3 https://dev.sourcefabric.org/secure/attachment/23028/incorrect.mp3

silan -b -f JSON /tmp/incorrect.mp3

Segmentation fault (core dumped)

I'm using the file from #3 since it came in handy. All the files i checked so far are segfaulting.

I have put the output of trace silan -b -f JSON /tmp/incorrect.mp3 in strace.txt and you can find the backtrace from gdb /usr/bin/silan core -ex bt in gdb.bt.txt.

Let me know if you need any more information.

[hairmare]

I went ahead and tried the latest master. If I compile that directly on stretchy everything works as intended (even the duration from #3):

{ "sound":[ [ 0.012358, 235.520000 ]], "file duration":235.520000, "sample rate":44100}

Maybe it's time for a new tag? I'm not sure about https://github.com/x42/silan/commit/a3a316d3e45f402971ecf32722758b6ab0ba06de though.

[x42]

Strikes me as a ffmpeg/libav issue and/or API change. I have not kept up on that end.

[hairmare]

I haven't either, but you seem to have fixed it already on master. I suspect your ffmpeg compat changes from https://github.com/x42/silan/compare/x42:b790611...x42:a3a316d fixed the issue.

FWIW, as per the debian source tarball they only seem to apply https://github.com/x42/silan/commit/3e83b80a7f558aa780ea4e42c7414b33482e1b1f during their build process.

Maybe tag https://github.com/x42/silan/commit/5d9a8e069f55abe22ad382e470d5a6229ca058fd as v0.3.3 (I'm leaving out https://github.com/x42/silan/commit/a3a316d3e45f402971ecf32722758b6ab0ba06de on purpose, maybe I'm wrong) and getting them to bump is the way forward.

Stretchy recently had it's freeze, but there might still be time to get a fix in.

In my CentOS packages the bump would also be appreciated 😉

[x42]

ok, so time for a new release.. I'm not too happy with a3a316d3e (that was a quick hack to get a job done) so your suggestion is good.

[x42]

https://github.com/x42/silan/releases/tag/v0.3.3 -- hopefully this resolves the issue.

[hairmare]

I'm reasonably sure it will, at least it did on CentOS. I'm trying to figure out how to raise the bump issue with Debian as we type.

[x42]

Debian watches the GH release page (with uscan). They will get notified automatically. Except IIRC silan was currently unmaintained there (the maintainer stepped down).

[hairmare]

Yupp, it's marked as orphaned in PTS.

[paddatrapper]

I can confirm that this has been fixed in 0.3.3 (tested on Debian testing and unstable)