search

x42 / xfade.lv2

stereo DJ X-fade plugin
GNU General Public License v2.0
11 stars 3 forks source link

lv2: update modgui and .TTL resources #2

Closed auto3000 closed 6 years ago

auto3000 commented 6 years ago

These resources are a backport from https://github.com/moddevices/mod-lv2-data at commit bc731ed68c44227530625592fb3ca7a687531771.

Signed-off-by: auto3000 auto3000@users.noreply.github.com

auto3000 commented 6 years ago

Thanks for your detailed code review and comments, this is a non-negligible efforts at this level of quality.

I actually think it makes sense to put "some" modgui resources into xfade.lv2 git project, to give the user a minimal feature. MOD devs can continue to use their custom MOD HTML UI release, as of today by pointing their build to current commit of the xfade.lv2 git project, in the future by avoiding to build xfade.lv2 with "Makefile MOD=1" from your remarks.

Note: MOD-SDK is more an assistant than an automatic generator (you have to click on a couple of interactive selectors), but this could be an idea to run such auto-generator from a config file. I think there is something to generate presets automatically in mod-lv2-data, but I did not give a try.

Did you speak with the MOD devs? In general they do not use upstream .ttl files anyway and provide their own.

I see the mod-lv2-data git project. This is a large addition of MOD HTML UI applicable to LV2 plugins from various provenances. From software maintenance point of view, if one modifies xfade.lv2 to remove a control port, this new interface version becomes incompatible with the related HTML found in mod-lv2-data git project. I suppose they did that approach to shorten development loop ; let imagine you have to push modgui resources in 100 git repository of 50 different developers. I think it is worth that MOD devs are more involved into development of the platform (mod-ui, mod-host, drivers etc) than getting their semi-automatic generated modgui resources integrated.

x42 commented 6 years ago

In general I try to avoid including anything that is auto-generated, simply because it can be auto-generated.

All x42-plugins that currently do have a MOD UI in the git-tree, do have a custom, hand-crafted or customized UI.

For this plugin, a custom UI might be nice to have. e.g.a display to visualize the fade-shape and fade-position, also perhaps a horizontal x-fade slider widget that matches a DJ-fader. Some annotation of the ports (show color or arrows for Left/Right) would be nice.

x42 commented 6 years ago

Just to be clear, I won't merge this auto-generated .html as-is. There is zero value in the auto-generated UI and it is just overhead to maintain this upstream.

x42 commented 6 years ago

[...]

if one modifies xfade.lv2 to remove a control port

You must never ever do that. Once a plugin is released it must be compatible and not break existing sessions that use the plugin.

auto3000 commented 6 years ago

Sure, this is up to you. I'm closing this pull request. Thanks for this exchange :+1: