Unable to build against ffmpeg >= 5

[dvzrv]

Hi! Similar to the issues with harvid (https://github.com/x42/harvid/issues/8) I am also unable to build xjadeo against ffmpeg >= 5. I was able to (partially) fix some of the deprecations in #49 but I am stuck with the same issue in regards to AVPicture (after applying the patches from the aforementioned PR):

xjadeo.c:444:34: error: ‘AVPicture’ undeclared (first use in this function); did you mean ‘AVPictureType’?
  444 |                 avpicture_fill ((AVPicture *)pFrameFMT, buffer, render_fmt, movie_width, movie_height);
      |                                  ^~~~~~~~~
      |                                  AVPictureType
xjadeo.c:444:34: note: each undeclared identifier is reported only once for each function it appears in
xjadeo.c:444:45: error: expected expression before ‘)’ token
  444 |                 avpicture_fill ((AVPicture *)pFrameFMT, buffer, render_fmt, movie_width, movie_height);
      |                                             ^

Full build log: xjadeo-0.8.10-build.log

[x42]

Can you try to replace the line with

av_image_fill_arrays (pFrameFMT->data, pFrameFMT->linesize, buffer, render_fmt, movie_width, movie_height, 0);

[x42]

Should be fixed since 9f62448b87dc345eb6e15b8e24b54339384c6ccb

[dvzrv]

Hm, I don't think so.

You merged https://github.com/x42/xjadeo/pull/49 a bit too fast. As mentioned in https://github.com/x42/xjadeo/pull/49#issue-1123445655 that commit does not work as intended (it does not build with it) and I wanted to find a better fix for it. Sorry, if that was not clear :S