x42 / zconvo.lv2

Zero Config Convolver
https://x42-plugins.com/x42/x42-zconvolver
GNU General Public License v2.0
16 stars 3 forks source link

Plugins file state doesn't propagate after DAW start #7

Closed myrrc closed 6 months ago

myrrc commented 6 months ago

Steps to reproduce:

  1. Open DAW (Reaper, in my case)
  2. Load Stereo convolver (in non-preset mode)
  3. Set a file. Save project. Reload DAW
  4. Although correct file will be saved in project state, it won't be shown in DAW's UI. When pressing "Browse" it will show user's home directory.

I'd think it's a Reaper problem, but another plugin https://github.com/swesterfeld/liquidsfz manages to propagate changes to UI correctly.

Reaper project file excerpt:

<REAPER_PROJECT 0.1 "7.14/linux-x86_64" 1713300630
  <...>
  <TRACK {837B7C68-77A1-9443-4B1D-8A7E425CC0FA}
    NAME ""
    PEAKCOL 16576
    BEAT -1
    AUTOMODE 0
    PANLAWFLAGS 3
    VOLPAN 0.37438658028591 0 -1 -1 1
    MUTESOLO 0 0 0
    IPHASE 0
    PLAYOFFS 0 1
    ISBUS 0 0
    BUSCOMP 0 0 0 0 0
    SHOWINMIX 1 0.6667 0.5 1 0.5 0 0 0
    FIXEDLANES 9 0 0 0
    SEL 1
    REC 0 0 1 0 0 0 0 0
    VU 2
    TRACKHEIGHT 0 0 0 0 0 0 0
    INQ 0 0 0 0.5 100 0 0 100
    NCHAN 2
    FX 1
    TRACKID {837B7C68-77A1-9443-4B1D-8A7E425CC0FA}
    PERF 0
    MIDIOUT -1
    MAINSEND 1 0
    <FXCHAIN
      WNDRECT 242 460 1682 236
      SHOW 2
      LASTSEL 1
      DOCKED 0
      BYPASS 0 0 0
      <LV2 "LV2: x42 - IR Convolver Stereo" http://gareus.org/oss/lv2/zeroconvolv#CfgStereo ""
        CFG 1 0 0 "airwindows - roomhuge"
        P buffered 1 dry -0.270001888275146484 wet -20.532001495361328125 enable 1
        <STATE
          P http://gareus.org/oss/lv2/zeroconvolv#ir /home/myrrc/music/lib/ir/teufelsberg/teufelsberg-01.flac 3
          F http://gareus.org/oss/lv2/zeroconvolv#gain 1 3
          I http://gareus.org/oss/lv2/zeroconvolv#predelay 0 3
          I http://gareus.org/oss/lv2/zeroconvolv#artificial_latency 0 3
          B http://gareus.org/oss/lv2/zeroconvolv#sum_inputs 0 3
          <V http://gareus.org/oss/lv2/zeroconvolv#channel_gain 4 http://lv2plug.in/ns/ext/atom#Float 3
            1 1 1 1
          >
          <V http://gareus.org/oss/lv2/zeroconvolv#channel_predelay 4 http://lv2plug.in/ns/ext/atom#Int 3
            0 0 0 0
          >
        >
      >
      PRESETNAME "airwindows - roomhuge"
      FLOATPOS 0 0 0 0
      FXID {9B7FD64E-77A0-A716-5198-350ABCF71F26}
      WAK 0 0
      BYPASS 0 0 0
      <LV2 "LV2i: liquidsfz (2 out)" http://spectmorph.org/plugins/liquidsfz ""
        CFG 0 0 0 kalimba
        MIDI midi_in 0 0 
        P level 0
        <STATE
          P http://spectmorph.org/plugins/liquidsfz#sfzfile "/home/myrrc/music/lib/sfz/dismantled-calimba/Dismantled Kalimba V1.sfz" 1
        >
      >
      PRESETNAME kalimba
      FLOATPOS 0 0 0 0
      FXID {D7581C5F-307D-3EF3-F450-42B45656551A}
      WAK 0 0
    >
    <ITEM
      POSITION 0
      SNAPOFFS 0
      LENGTH 5.5
      LOOP 1
      ALLTAKES 0
      FADEIN 1 0.01 0 1 0 0 0
      FADEOUT 1 0.01 0 1 0 0 0
      MUTE 0 0
      SEL 1
      IGUID {B4113562-0E64-6E1C-156B-9FA44F1CF322}
      IID 1
      NAME 01-240416_2112.wav
      VOLPAN 1 0 1 -1
      SOFFS 1.5
      PLAYRATE 1 1 0 -1 0 0.0025
      CHANMODE 0
      GUID {A0F3EEA4-99F4-F538-58D8-6A711097AA7C}
      RECPASS 1
      <SOURCE WAVE
        FILE "src/01-240416_2112.wav"
      >
    >
  >
>
myrrc commented 6 months ago

OS: Debian 13 Trixie Reaper v7.14 zconvolv version 0.7.1

x42 commented 6 months ago

Since this works in the LV2 reference host (jalv) as well as other LV2 hosts (Ardour, Carla). This is a Reaper specific issue. Nothing I can do here, please notify Justin about this.

myrrc commented 6 months ago

Ok, thanks! I assume other issue (no sound in preset plugins ) may also be Reaper-specific (state of presets is not propagated to project file).

myrrc commented 6 months ago

I played with this a bit -- the problem seems to be with Reaper indeed: when changing preset to a new one, the convolver sometimes just doesn't pick it and uses the old version.

Checking the code of liquidsfz (literally the only plugin working correctly so far with file checker), may it be related to midnam and UI update?

myrrc commented 5 months ago

For linking: https://forum.cockos.com/showthread.php?p=2780193#post2780193

In convoLV2 this is indeed a plugin issue

x42 commented 5 months ago

Thanks for the backlink.

Keep in mind that convoLV2 is end of life and should not be used in new sessions.

As for this issue, I'm in contact with Justin.