search

x4e / PaperBin

An experiment at improving the performance of PaperMC
Other
96 stars 8 forks source link

Added github action, upload artifact #19

Closed not-ivy closed 3 years ago

AlexProgrammerDE commented 3 years ago

This won't work at all. You aren't even compiling paperbin. You are just downloading a soon outdated build and make the ci stuck at running a mc server on it that won't stop because no human is gonna interrupt/stop it.

AlexProgrammerDE commented 3 years ago

setup.sh is not needed at all btw because you can execute all those commands directly in the workflow file.

x4e commented 3 years ago

Please try running the script by yourself before claiming it won't work.

a soon outdated build

Paper 1.12 is no longer being updated

running a mc server on it that won't stop

Minecraft servers automatically quit if the eula has not been agreed to

x4e commented 3 years ago

Thank you @sourTaste000 , this is very good.

In the future it will be desirable to make this also compile the native library but for now thats not too much of a worry.

Thanks.

AlexProgrammerDE commented 3 years ago

oops... Sorry I must have misread the workflow file then. Sorry for interrupting you.