search

x64Bits / solid-icons

The simplest way to use icons in SolidJS
https://solid-icons.vercel.app
MIT License
284 stars 18 forks source link

Set "types" field in "exports" to fix typescripts new "bundler" module resolution #30

Closed tobias-walle closed 12 months ago

tobias-walle commented 1 year ago

Resolves #29

x64Bits commented 1 year ago

Since Typescript 5 is out of beta and is a stable version we should consider using this, could you correct the name of the file please? specifically would types.d.ts be or am I missing something sorry?

thanks for the PR.

pikaju commented 1 year ago

@x64Bits The generated types file appears to be index.d.ts, not types.d.ts: image

x64Bits commented 1 year ago

It's true, I had forgotten which type file is called index.d.ts, I'm going to merge it, thank you very much 🙌🏼!

pikaju commented 1 year ago

I'm just wondering @tobias-walle, why did you write .d.js instead of .d.ts?

tobias-walle commented 1 year ago

I'm just wondering @tobias-walle, why did you write .d.js instead of .d.ts?

Good catch! This was an error on my side.

I just updated the branch, so it uses now the correct file endings.

pikaju commented 12 months ago

Awesome! @x64Bits please merge when you have time, the TypeScript error is bugging me every day

x64Bits commented 12 months ago

It is already merged, thank you very much for the work and sorry, I did not receive notification about the changes.