search

x64Bits / solid-icons

The simplest way to use icons in SolidJS
https://solid-icons.vercel.app
MIT License
295 stars 19 forks source link

break apart by sources please #4

Closed tomByrer closed 2 years ago

tomByrer commented 2 years ago

Seems like to get only 2 icons, I have to npm i all 14156 icons on my drive? If true, maybe split each icon family as a separate package? I'd rather save my bandwidth for cat videos ;)

x64Bits commented 2 years ago

Hi Tom, i am going to consider this very seriously, i also suffer downloading heavy size libraries and it seems fair to me, i just need to check how much i have to change to publish separate packages but it seems quite logical, i have seen that many libraries are doing it.

tomByrer commented 2 years ago

Thanks for your consideration!

TBH, for the project I looked at this for, I just copy/pasted the raw SVG. An online icon searcher that had a way to simply copy the raw SVG could be another workaround.

x64Bits commented 2 years ago

I think we will postpone this because it represents additional work and I don't think we are a very big lib yet, what do you think?

x64Bits commented 2 years ago

I'm already adding the option on the website to copy the JSX component and the SVG, thanks for giving the idea, this week I sent this.

x64Bits commented 2 years ago

A new version of the website has already been launched where two buttons have been added to copy the icon in different formats, JSX and SVG.

tomByrer commented 2 years ago

Thanks for your hard work! I like the JSX & SVG options also.