search

x64Bits / solid-icons

The simplest way to use icons in SolidJS
https://solid-icons.vercel.app
MIT License
284 stars 18 forks source link

Doesn't work on Astro 2.6 #41

Closed suhaylmv closed 11 months ago

suhaylmv commented 1 year ago

I moved my project to a newer version of Astro (2.6) and all the solid-icons (except the hamburger one which I used for the navbar) I've used appear in the DOM but are invisible. I didn't have this issue with the older version of Astro 2.3

kseikyo commented 1 year ago

I also upgraded Astro to 2.6 and now I can't change with the color property nor by applying a color to the component with css.

The only way I can currently style colors is by changing the fill property, but that wasn't the case before the upgrade.

Current version of solid icons on package.json is ^1.0.4

Here's an example of a FaSolidCheck

import { FaSolidCheck } from "solid-icons/fa";
...
<Kobalte.Indicator class="bg-deepblue" {...props}>
    <FaSolidCheck color="#fff" class="p-0.5 text-white" />
</Kobalte.Indicator>

image

x64Bits commented 1 year ago

Hi thanks for waiting, can you take a look at the 1.0.10 version? recently i sent a solution for that.

suhaylmv commented 11 months ago

Now it works good. Thank you for fixing this issue