search

x64Bits / solid-icons

The simplest way to use icons in SolidJS
https://solid-icons.vercel.app
MIT License
284 stars 18 forks source link

Does not work with latest Astro & Solid #46

Closed marvin-j97 closed 12 months ago

marvin-j97 commented 1 year ago

Reproduction: https://github.com/marvin-j97/solid-1.7-icons

Icon is invisible. Changing client:load to client:only fixes it.

marvin-j97 commented 1 year ago

Probably related to https://github.com/x64Bits/solid-icons/issues/41 ? Maybe https://github.com/x64Bits/solid-icons/issues/45 as well

densumesh commented 1 year ago

the svg path seems to be in quotes in the html causing the svg to not render. image

x64Bits commented 1 year ago

Hello, I am very aware of the problem that solid-icons are having when used in astro.

I hadn't given an answer because I wanted to reply with the solution, but it's taking me longer to figure out why this is happening, I think it's a problem in the build because in solid you can't just do <svg>{iconSrc.c}< /svg>, I'm concentrating on fixing this, I'll bring news over the weekend, thanks!

x64Bits commented 1 year ago

Hi everyone, i comment here about it https://github.com/x64Bits/solid-icons/issues/41#issuecomment-1620939575

marvin-j97 commented 12 months ago

Working for me @x64Bits :+1:

x64Bits commented 12 months ago

Great @marvin-j97! Thank you very much for notifying this and the effort for the code to reproduce the error helped a lot!