x64Bits / solid-icons

The simplest way to use icons in SolidJS
https://solid-icons.vercel.app
MIT License
284 stars 18 forks source link

Babel Optimization Error: Module Size Exceeding 500KB #61

Open 0-don opened 3 months ago

0-don commented 3 months ago

Description

When building a SolidJS project using solid-icons, Babel throws an optimization error indicating that the styling of some modules exceeds the maximum size of 500KB. This is occurring specifically with solid-icons/fa/index.js and solid-icons/tb/index.js. The error message is repeated multiple times, suggesting that the issue persists through multiple attempts to compile.

Steps to Reproduce

  1. Set up a SolidJS project with @solidjs/start.
  2. Include the solid-icons package in the dependencies.
  3. Run the build script.

Expected Behavior

The build should complete without errors, and Babel should handle the module size appropriately, possibly by splitting or tree-shaking.

Actual Behavior

The following error is received:

[BABEL] Note: The code generator has deoptimised the styling of /home/don/MEGA/Projects/coding.global-web/node_modules/solid-icons/tb/index.js as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /home/don/MEGA/Projects/coding.global-web/node_modules/solid-icons/fa/index.js as it exceeds the max of 500KB.

Environment

Possible Solution

Could this be an issue with how the icons are being imported or bundled? Is there a recommended way to import solid-icons that could avoid this problem?

Additional Context

image

x64Bits commented 3 months ago

Hi @0-don thanks for sharing, solid-start receive new updates recently, i will check this and go back with update soon.

sparklog commented 1 month ago

In dev mode, Babel shows the error as above. However, when I built it, app works well. I think 'tree shake' function solved this issue during the build process. Am I right?

diegovfeder commented 3 days ago

Just noticed the same issue here in a personal proj.