search

x64dbg / x64dbgpy

Automating x64dbg using Python, Snapshots:
https://ci.appveyor.com/project/mrexodia/x64dbg-python/build/artifacts
MIT License
1.47k stars 70 forks source link

-outputtuple is removed in swig 4.0.0. #36

Closed ngo closed 5 years ago

ngo commented 5 years ago

Currently this option is used here: https://github.com/x64dbg/x64dbgpy/blob/0cba3acd66ca4288b2ea0abd447edc6121a8a245/swig/setup.py#L33

As per https://fossies.org/linux/privat/swig-4.0.0.tar.gz/swig-4.0.0/CHANGES.current (search for #1340), this option was removed from swig 4.0.0.

What is the purpose of including this option here?

ngo commented 5 years ago

@realgam3, you seem to be the author of the main codebase here. Do you remember any specific reason for using -outputtuple switch for swig? What would be the best way to change code so that it's safe to remove?

techbliss commented 5 years ago

only thing i can find on the subject is https://github.com/swig/swig/commit/0a9b36d3beb0055ad685583fd8d91c715d8e0d7e

ngo commented 5 years ago

@techbliss , the commit you mentioned disables support for this option in SWIG, but does not shed any light on whether x64dbgpy actually uses the behavior provided by -outputtuple. From my very limited testing removing this option does not impact any exisiting functions of x64dbgpy, but you can never be sure...

techbliss commented 5 years ago

Yeah you never know, just wierd that the auther of swig do not know either.

mrexodia commented 5 years ago

This isn't really solved, but I just fixed swig to an older version. Eventually the plan is to do manual bindings with pybind11 anyway because swig is too fugly.