search

x64dbg / x64dbgpy

Automating x64dbg using Python, Snapshots:
https://ci.appveyor.com/project/mrexodia/x64dbg-python/build/artifacts
MIT License
1.47k stars 70 forks source link

Stop shipping binaries in the repo and purge them from commits history #45

Closed KOLANICH closed 4 years ago

mrexodia commented 4 years ago

Which binaries would that be?

KOLANICH commented 4 years ago

All the files that are binary. git doesn't handle them efficiently, they cause the repo size grow a lot (there exist repos of libraries over a GiB in size because their maintainers considers rewriting history and/or storing binary files in other places as inacceptable), so they should be removed from history too. Especially exes available in other places - instead instructions how to get them should be provided and maybe a script doing it.

mrexodia commented 4 years ago

There are no binaries that are irrelevant. Git is not meant for frequent binary updates, but the binaries here are not updated frequently and it’s often not possible to reproduce the stuff without binaries.

KOLANICH commented 4 years ago

Then GIT LFS should be used for them.

mrexodia commented 4 years ago

No. I’m confused about your issues. You seem to open random issue related to best practices, without actually trying to understand what’s going on in this project. The binaries here are a total of maybe 200kb. Nobody in their right mind should be using git lfs for that.

On Thu, 5 Dec 2019 at 20:11, KOLANICH notifications@github.com wrote:

Then GIT LFS should be used for them.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/x64dbg/x64dbgpy/issues/45?email_source=notifications&email_token=AASYFGOKIDYFT4DIEQ45MWLQXFG73A5CNFSM4JVUTTN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGBZLDA#issuecomment-562271628, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASYFGOINOWOUMHIEC6ULJDQXFG73ANCNFSM4JVUTTNQ .