search

x86dev / docker-ttrss

Tiny Tiny RSS feed reader as a Docker image.
54 stars 41 forks source link

SELF_URL_PATH configuration broken since today #39

Closed languitar closed 4 years ago

languitar commented 4 years ago

With this commit the config file template has changed and the dist entry for SELF_URL_PATH now looks like:

define('SELF_URL_PATH', '%SELF_URL_PATH');

This isn't supported by the current sed-magic used to configure the file and hence ttrss doesn't start anymore after an upgrade.

eric-pierce commented 4 years ago

I ran into this same problem - it can be fixed by manually modifying config.php but is not persistent and upon container restart it will revert.

Harvester57 commented 4 years ago

I ran into this same problem - it can be fixed by manually modifying config.php but is not persistent and upon container restart it will revert.

Can't you just commit the change to your container ?

eric-pierce commented 4 years ago

@Harvester57 I don't want to modify the container as it would be over-written if/when a new version is pulled down from dockerhub.

I just created pull request #41 to resolve this issue. @x86dev please review!

x86dev commented 4 years ago

Should be fixed now by the patch from @eric-pierce, which just got merged into the tree.

trammel commented 4 years ago

As this affects the base image, could you release a new one on dockerhub please?

x86dev commented 4 years ago

It should auto-build over at Docker Hub here: https://hub.docker.com/repository/docker/x86dev/docker-ttrss/builds

Not sure why it didn't this time -- will keep an eye on it, but for now I've just triggered a manual build.

bugwelle commented 4 years ago

Pulled the latest image an hour ago. Everything works again. Thanks! 😄

x86dev commented 4 years ago

Cool, thanks for verifying!