search

x89 / Tea

Tea reminder
Other
19 stars 3 forks source link

Tea.sh does not print usage when the --help flag is used. #13

Closed Happy0 closed 9 years ago

Happy0 commented 9 years ago

Tea.sh does not print the usage when the --help flag is used.

Steps to reproduce:

  1. Run tea.sh using the --help flag.

Expected: Tea.sh prints the usage.

Actual: Tea.sh executes as normal, informing you that your tea is ready in 6 minutes.

Log: [happy0@delta Tea]$ ./tea.sh --help

You are using tea.flac. Have no fear! None! You will be warned when your tea is ready. ^C [happy0@delta Tea]$

Revision: 9e928ba90484283f856515cced828d4765996daf

anlutro commented 9 years ago

https://github.com/x89/Tea/blob/9e928ba90484283f856515cced828d4765996daf/tea.sh#L19

This removes all arguments ($1, $2 etc.) which means that $1 is empty later in the script, and $# is always 0.

moopie commented 9 years ago

I think this is an important feature that should be added as fast as possible

just the fact that it is here for more than a day with no response from the dev is a bad sign.

Happy0 commented 9 years ago

Indeed. I no longer have confidence in the management of this project.

I think it's time for a fork! Would you like the role of 'deputy product manager', @moopie?

x89 commented 9 years ago

I will quickly merge the request.

anlutro commented 9 years ago

I think this project should be rewritten in Rust. Rust advertises memory safety which is very important, because the script needs to remember to remind the user that their tea is ready.

Happy0 commented 9 years ago

I think our fork should be rewritten in Haskell. Haskell promotes explicitly typed side effects which is very important because reminding the user that their tea is ready is effectful as it plays an audio clip and prints to standard out. This dangerous side effect should be explicitly captured.

anlutro commented 9 years ago

Reminding a user that their tea is ready counts as a side effect. Haskell does not allow it.

Happy0 commented 9 years ago

This minor issue can be resolved by attaching a thermometer to the CPU which heats up due to the work required to execute the pure functions in tea.sh which can be captured, despite the limitation of Haskell not allowing side effects. We will write the pure functions in a way that predictably heats up the CPU to transmit 'your tea is ready' in morse code.

Happy0 commented 9 years ago

Invalid? Our fork is more urgent than I thought!

x89 commented 9 years ago

Watch it you or it's getting tagged wontfix.

On Wed, May 13, 2015 at 8:56 AM, Gordon Martin notifications@github.com wrote:

Invalid? Our fork is more urgent than I thought!

— Reply to this email directly or view it on GitHub https://github.com/x89/Tea/issues/13#issuecomment-101557443.

anlutro commented 9 years ago

Fixed in https://github.com/x89/Tea/commit/44aff899e1b29ed60ce28328ce2d2eeb6eb45471

Happy0 commented 9 years ago

Thanks @anlutro. Congratulations on your new job as a maintainer for this prestigious project!

x89 commented 9 years ago

+1, highly committed individual.