Lms 2589 reconcile mod assign assignment submitted

[lzabo]

Description

• add get_verb function
• set verb to completed at the assignment_submitted when JISC data is set.

Related Issues

• LMS-2589

PR Type

• Enhancement

[lzabo]

There are other events containing the 'submitted' and 'completed' verbs e.g. courses, attempts, modules etc

Therefore, I think we should change the get_verb util to be get_assignment_verb and perform the 'send_jisc_check' inside the util

I think this approach is easier to read, maintain and avoids potential clashes further down the line. It also follows the pattern already in place for get_scorm_verb

I don’t agree.

I guess we need a function which contains the correct verbs and also that will be great if we add these verb settings to the other functions as well.

pros: All verb will be in one place. Easy to follow standards. Developer friendly version, It helps to avoid duplicated elements and to avoid duplicated code and to avoid spelling mistakes.

cons: .

The get_scorm_verb function comes back with different statuses which is good but in my version it should call my get_verb function three times, instead of they add time to time verbs, (for example completed verb).

[gordonmacqueen-lp]

I don’t agree.

I guess we need a function which contains the correct verbs and also that will be great if we add these verb settings to the other functions as well.

pros: All verb will be in one place. Easy to follow standards. Developer friendly version, It helps to avoid duplicated elements and to avoid duplicated code and to avoid spelling mistakes.

cons: .

The get_scorm_verb function comes back with different statuses which is good but in my version it should call my get_verb function three times, instead of they add time to time verbs, (for example completed verb).

OK - let's go with your suggested approach. I had misunderstood that the verbs are reused between the different event types