search

xAPI-vle / moodle-logstore_xapi

A Moodle plugin to send xAPI statements to an LRS using events in the Moodle logstore.
GNU General Public License v3.0
75 stars 85 forks source link

Allow customization of identifying actors #777

Closed sei-ebram closed 4 months ago

sei-ebram commented 3 years ago

Description

  1. homePage - Always set to app_url
  2. name - Either username, or id, depending on a setting.

Both of these are quite limiting. homePage set to app_url makes sense for local accounts, but not for OAuth2 accounts according to the xAPI spec. If a user is accessing Moodle via OAuth2, then the homePage should reflect the OAuth2 issuer, and not Moodle.

In addition, in the specific case of OAuth2 users, but most likely others, both "id" and "username" aren't relevant identifiers for an account. Instead, this should be more freely customizable and include a list of user properties to choose from.

sei-ebram commented 3 years ago

image

davidpesce commented 4 months ago

Happy to review PRs, but will be closing this as part of a cleanup/roadmap focus.