Fix .gitignore - Githubissues

xAPI-vle / moodle-logstore_xapi

A Moodle plugin to send xAPI statements to an LRS using events in the Moodle logstore.

GNU General Public License v3.0

75 stars 85 forks source link

Fix .gitignore #782

Closed ghost closed 1 year ago

ghost commented 3 years ago

Description

The .gitignore file includes version.php, therefore when we commit the xAPI plugin to our internal Moodle repo, it does not include version.php, which is of course a required file for Moodle. Whilst we can manually modify the .gitignore, the source then deviates from the plugin, potentially resulting in merge conflicts. Regardless, the version.php file should not be in .gitignore anyway.

Version

master at e5be1b7e55d16e3bba244e91f663cb75169a8a50 on 2018082100

Steps to reproduce the bug

Copy the xAPI plugin into an existing Moodle Git repository
Push this to the remote

Expected behaviour

version.php should be included, without needing to modify .gitignore

Actual behaviour

version.php is not pushed, as it is in .gitignore.

davidpesce commented 1 year ago

This has been resolved. We are now using the plugin-release github actions from Moodle HQ.