Fix timezone bug #802 - Githubissues

xAPI-vle / moodle-logstore_xapi

A Moodle plugin to send xAPI statements to an LRS using events in the Moodle logstore.

GNU General Public License v3.0

75 stars 85 forks source link

Fix timezone bug #802 #803

Closed brendanheywood closed 2 years ago

brendanheywood commented 2 years ago

Description

Fixes the timezone bug Related Issues
802

PR Type

brendanheywood commented 2 years ago

Notes to reviewers, it's unclear to me why the timezone is set at all, it was introduced in caea2c20 but that commit is epic and its not clear if it was intentional or not. @ryansmith94 might have more context?

My knee jerk reaction would be to simply remove it, but assuming its needed this pr is safer

I found this because it was the root cause of this bug:

https://github.com/moodleou/moodle-report_customsql/issues/97

brendanheywood commented 2 years ago

Turns out this is already done almost exactly the same here:

https://github.com/xAPI-vle/moodle-logstore_xapi/pull/775/files