deprecation warnings still shown on Moodle 4.1.5+

[jpahullo]

Description

• Just installed the plugin on my dev Moodle instance, we have seen several warnings about deprecated events.
• Follows what experienced on #837

Version

• Moodle 4.1.5+
• Plugin version: 2022101800 (installed and upgraded from Moodle administration web).

Steps to reproduce the bug

1. Install this plugin just on a fresh Moodle 4.1.5+
2. Go to administration page, and seen this output (even with the plugin deactivated):

core\event\content_viewed has been deprecated. Please extend base event or other relevant abstract class.
line 32 of /lib/classes/event/content_viewed.php: call to debugging()
line 137 of /lib/classes/component.php: call to include_once()
line ? of unknownfile: call to core_component::classloader()
line ? of unknownfile: call to spl_autoload_call()
line 920 of /lib/classes/component.php: call to class_exists()
line 62 of /report/eventlist/classes/list_generator.php: call to core_component::get_component_classes_in_namespace()
line 101 of /admin/tool/log/store/xapi/src/transformer/get_event_function_map.php: call to report_eventlist_list_generator::get_all_events_list()
line 133 of /admin/tool/log/store/xapi/settings.php: call to src\transformer\get_event_function_map()
line 90 of /admin/tool/log/classes/plugininfo/logstore.php: call to include()
line 46 of /admin/tool/log/settings.php: call to tool_log\plugininfo\logstore->load_settings()
line 81 of /lib/classes/plugininfo/tool.php: call to include()
line 735 of /admin/settings/plugins.php: call to core\plugininfo\tool->load_settings()
line 8877 of /lib/adminlib.php: call to require()
line 8758 of /lib/adminlib.php: call to admin_get_root()
line 204 of /admin/plugins.php: call to admin_externalpage_setup()
core\event\course_module_instances_list_viewed has been deperecated. Please use core\event\course_module_instance_list_viewed instead
line 31 of /lib/classes/event/course_module_instances_list_viewed.php: call to debugging()
line 137 of /lib/classes/component.php: call to include_once()
line ? of unknownfile: call to core_component::classloader()
line ? of unknownfile: call to spl_autoload_call()
line 920 of /lib/classes/component.php: call to class_exists()
line 62 of /report/eventlist/classes/list_generator.php: call to core_component::get_component_classes_in_namespace()
line 101 of /admin/tool/log/store/xapi/src/transformer/get_event_function_map.php: call to report_eventlist_list_generator::get_all_events_list()
line 133 of /admin/tool/log/store/xapi/settings.php: call to src\transformer\get_event_function_map()
line 90 of /admin/tool/log/classes/plugininfo/logstore.php: call to include()
line 46 of /admin/tool/log/settings.php: call to tool_log\plugininfo\logstore->load_settings()
line 81 of /lib/classes/plugininfo/tool.php: call to include()
line 735 of /admin/settings/plugins.php: call to core\plugininfo\tool->load_settings()
line 8877 of /lib/adminlib.php: call to require()
line 8758 of /lib/adminlib.php: call to admin_get_root()
line 204 of /admin/plugins.php: call to admin_externalpage_setup()
core\event\role_capabilities_updated has been deprecated. Please use core\event\capability_assigned instead
line 31 of /lib/classes/event/role_capabilities_updated.php: call to debugging()
line 137 of /lib/classes/component.php: call to include_once()
line ? of unknownfile: call to core_component::classloader()
line ? of unknownfile: call to spl_autoload_call()
line 920 of /lib/classes/component.php: call to class_exists()
line 62 of /report/eventlist/classes/list_generator.php: call to core_component::get_component_classes_in_namespace()
line 101 of /admin/tool/log/store/xapi/src/transformer/get_event_function_map.php: call to report_eventlist_list_generator::get_all_events_list()
line 133 of /admin/tool/log/store/xapi/settings.php: call to src\transformer\get_event_function_map()
line 90 of /admin/tool/log/classes/plugininfo/logstore.php: call to include()
line 46 of /admin/tool/log/settings.php: call to tool_log\plugininfo\logstore->load_settings()
line 81 of /lib/classes/plugininfo/tool.php: call to include()
line 735 of /admin/settings/plugins.php: call to core\plugininfo\tool->load_settings()
line 8877 of /lib/adminlib.php: call to require()
line 8758 of /lib/adminlib.php: call to admin_get_root()
line 204 of /admin/plugins.php: call to admin_externalpage_setup()
mod_lesson\event\highscore_added has been deprecated. Since the functionality no longer resides in the lesson module.
line 31 of /mod/lesson/classes/event/highscore_added.php: call to debugging()
line 137 of /lib/classes/component.php: call to include_once()
line ? of unknownfile: call to core_component::classloader()
line ? of unknownfile: call to spl_autoload_call()
line 920 of /lib/classes/component.php: call to class_exists()
line 62 of /report/eventlist/classes/list_generator.php: call to core_component::get_component_classes_in_namespace()
line 101 of /admin/tool/log/store/xapi/src/transformer/get_event_function_map.php: call to report_eventlist_list_generator::get_all_events_list()
line 133 of /admin/tool/log/store/xapi/settings.php: call to src\transformer\get_event_function_map()
line 90 of /admin/tool/log/classes/plugininfo/logstore.php: call to include()
line 46 of /admin/tool/log/settings.php: call to tool_log\plugininfo\logstore->load_settings()
line 81 of /lib/classes/plugininfo/tool.php: call to include()
line 735 of /admin/settings/plugins.php: call to core\plugininfo\tool->load_settings()
line 8877 of /lib/adminlib.php: call to require()
line 8758 of /lib/adminlib.php: call to admin_get_root()
line 204 of /admin/plugins.php: call to admin_externalpage_setup()
mod_lesson\event\highscores_viewed has been deprecated. Since the functionality no longer resides in the lesson module.
line 31 of /mod/lesson/classes/event/highscores_viewed.php: call to debugging()
line 137 of /lib/classes/component.php: call to include_once()
line ? of unknownfile: call to core_component::classloader()
line ? of unknownfile: call to spl_autoload_call()
line 920 of /lib/classes/component.php: call to class_exists()
line 62 of /report/eventlist/classes/list_generator.php: call to core_component::get_component_classes_in_namespace()
line 101 of /admin/tool/log/store/xapi/src/transformer/get_event_function_map.php: call to report_eventlist_list_generator::get_all_events_list()
line 133 of /admin/tool/log/store/xapi/settings.php: call to src\transformer\get_event_function_map()
line 90 of /admin/tool/log/classes/plugininfo/logstore.php: call to include()
line 46 of /admin/tool/log/settings.php: call to tool_log\plugininfo\logstore->load_settings()
line 81 of /lib/classes/plugininfo/tool.php: call to include()
line 735 of /admin/settings/plugins.php: call to core\plugininfo\tool->load_settings()
line 8877 of /lib/adminlib.php: call to require()
line 8758 of /lib/adminlib.php: call to admin_get_root()
line 204 of /admin/plugins.php: call to admin_externalpage_setup()

Expected behaviour

• No deprecation warning seen.

Actual behaviour

• List of deprecated events are shown.

Server information

• mysql

Client information

• OS: linux/ubuntu
• Browser: brave 1.48.164 Chromium: 110.0.5481.100 (64 bits)

Additional information

[davidpesce]

Hi @jpahullo,

I cannot replicate this on any of the 4.1.x instances that we have. Additionally, if you search the plugin code for the event names (that the debug statements are identifying), they are not present within this plugin.

• Can you confirm this is a fresh install of Moodle? (ie, not an upgrade)
• Is the plugin a fresh install from the latest (either on github and/or the Moodle plugin directory)?

You've got some old code somewhere that does not represent the latest version of the plugin.