search

xBalbinus / client-contracts-frontend

0 stars 1 forks source link

Remove minimist and nth-check #7

Open aashidham opened 1 year ago

aashidham commented 1 year ago

Both are dependabot vulns when porting this repo: https://github.com/filecoin-project/fvm-starter-kit-deal-making/security/dependabot

One critical, one not. Either way, not a great look for new devs trying this out.

xBalbinus commented 1 year ago

Done

aashidham commented 1 year ago

Not correctly migrated, or fixed. I see this with every git push:

a@As-MacBook-Air fvm-starter-kit-deal-making % git push
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 8 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 335 bytes | 335.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
remote: 
remote: GitHub found 2 vulnerabilities on filecoin-project/fvm-starter-kit-deal-making's default branch (1 critical, 1 high). To find out more, visit:
remote:      https://github.com/filecoin-project/fvm-starter-kit-deal-making/security/dependabot
remote: 
To github.com:filecoin-project/fvm-starter-kit-deal-making.git
   9c5909d..3c852b4  main -> main