xBimTeam / XbimEssentials

A .NET library to work with data in the IFC format. This is the core component of the Xbim Toolkit
https://xbimteam.github.io/
Other
491 stars 173 forks source link

Federation model: when models are combined, geometry occur wrong #381

Open yinweib opened 3 years ago

yinweib commented 3 years ago

as the title image

martin1cerny commented 3 years ago

I'm sorry, but it isn't very clear what is actually wrong.

CBenghi commented 3 years ago

Hi Martin, I think it might be something to do with the alignment of models or some single/double precision issue. Those circles appear segmented, which might be due to large displacements (in turn depending on federation).

I had implemented a solution for this in xbim4, but I'm not sure if it's been retained in the same way in xbim5, because I know we have both found independent solutions for this.

It's possible that WindowsUI needs some changes to adapt to what you have done in geometry/essentials.

CBenghi commented 3 years ago

Incidentally, there was also some code I had in xbim4 that detected when models where meshed with adjustWCS true/false, to federate correctly, but I think it's been suspended in xbim5.

@yinweib, if you can share simplified models, it would be easier to understand the issue.

yinweib commented 3 years ago

@CBenghi can you apply your solution in xbim4, I don't know where to find it ,thank you

CBenghi commented 3 years ago

@yinweib, are you using windowsUI or webUI?

yinweib commented 3 years ago

@CBenghi windowsUI

CBenghi commented 3 years ago

Try with this branch: https://github.com/xBimTeam/XbimWindowsUI/tree/maintenance/Xbim4.x

yinweib commented 3 years ago

@CBenghi I don't find difference during comparing the code you supplied in xbim4.x and other version code ,can you configure that ,thank you

CBenghi commented 3 years ago

@yinweib, there are enormous differences between the two codebases. My suggestion is to checkout the code of the maintenance/Xbim4.x branch on windowsUI, run that version locally to see if it manages your visuals correctly. In case it does, at least, we understand where the problem might be.

If it does not you will have to share more information, otherwise we will not be able to help.

yinweib commented 3 years ago

@CBenghi I see what your mean for, thank you