xBimTeam / XbimEssentials

A .NET library to work with data in the IFC format. This is the core component of the Xbim Toolkit
https://xbimteam.github.io/
Other
485 stars 172 forks source link

Depended ManagedEsent package is deprecated #504

Open vchekalin opened 1 year ago

vchekalin commented 1 year ago

Xbim.IO.Esent has a dependency on ManagedEsent(>= 1.9.4) which is currently deprecated. Microsoft provide the alternative package Microsoft.Database.ManagedEsent. Our company policy doesn't allow to use deprecated packages, but there is no way to delete the package ManagedEsent as it depends on Xbim.IO.Esent.

Assemblies and versions affected:

Xbim.IO.Esent 5.1.341

Steps (or code) to reproduce the issue:

  1. Add Xbim.IO.Esent package to a project
  2. Try to delete ManagedEsent

Expected behavior:

The dependency to the new alternative package must be set.

martin1cerny commented 1 year ago

Hi Victor,

thank you for spotting this issue. It is certainly not a good practise to reference deprecated packages. Can you try to clone Xbim.Essentials code and replace ManagedEssent by Microsoft.Database.ManagedEsent? Contributions through pull requests are most welcome.

andyward commented 1 year ago

I think this is just in master (and latest Nuget). If you check out the develop builds (which targets netstandard2 up) we've removed support for ManagedEssent in place of the newer dependency. I think we had to drop pre net472 support as a result.

You can get the develop Essentials and related packages from Myget https://www.myget.org/feed/xbim-develop/package/nuget/Xbim.IO.Esent

The plan is to merge develop to master in the month or so.

vchekalin commented 1 year ago

Hi,

Thank you for your prompt response. Actually the Microsoft.Database.ManagedEsent package is already referenced to the Xbim.IO.Esent project, but only for the netstandard2.0, while ManagedEssent is referenced in case if net47 is used as a target framework.

I checked the developed branch, the deprecated ManagedEssent is deleted. Will wait for the new release.