search

xBimTeam / XbimExchange

XbimExchange contains several COBie schemas and serialisation functions as well as the Model Validation library adopted by theNBS digital toolkit.
https://xbimteam.github.io/
Other
46 stars 41 forks source link

COBieLiteUK: Conversion from IFC sets Address lines equal to .NET Type Name #18

Open MichaelBuehler opened 7 years ago

MichaelBuehler commented 7 years ago

On conversion from IFC2x3 or IFC4, the Contact street will be set to .NET Type Name.

From XML export

Xbim.Ifc4.OptionalItemSet`1[Xbim.Ifc4.MeasureResource.IfcLabel]

Probably there is no .ToString() implementation for ItemSet as code assumes:

MappingIfcActorToContact.cs Line 87 and 145 target.Street = postal.AddressLines != null && postal.AddressLines.Any() ? string.Join(", ", postal.AddressLines) : null;

Using version on NuGET: Essentials 4.0.15 and Exchange 4.0.4.

Jero9999 commented 7 years ago

I am also getting this one

CBenghi commented 7 years ago

Hello @Jero9999, I'm having problem following this thread. The current codebase is 4.0.6-V0005 using Essentials 4.0.28-V017, does the error still apply? A test file would help. Claudio

Jero9999 commented 7 years ago

The unit test you wrote for issue 17 (https://github.com/xBimTeam/XbimExchange/issues/17) shows this issue as well.

CBenghi commented 7 years ago

Hello @Jero9999, investigating this I've found issues in Essentials, I'll fix this as soon as the essentials bug is gone. Thanks, Claudio