search

xBimTeam / XbimGeometry

XbimGeometry contains the CLR interop libraries and the c++ engine used to compute the 3D geometry of models.
https://xbimteam.github.io/
Other
260 stars 131 forks source link

Wall with holes not working in 5, but did in 4 #356

Open ManIkWeet opened 3 years ago

ManIkWeet commented 3 years ago

A customer sent us a model that contains many walls that aren't handled properly in XbimXplorer 5, but worked 'fine' in XbimXplorer 4. There are many warnings/errors logged but a decent result does get created in 4, and in 5 the result is definitely wrong.

Assemblies and versions affected:

Name Assembly version File version: Xbim.Common 5.1.0.0 5.1.0.332 Xbim.Geometry.Engine.Interop 5.1.0.0 5.1.430.0 Xbim.Ifc 5.1.0.0 5.1.324.0 Xbim.Ifc2x3 5.1.0.0 5.1.0.332 Xbim.Ifc4 5.1.0.0 5.1.0.332 Xbim.IO.Esent 5.1.0.0 5.1.0.332 Xbim.IO.MemoryModel 5.1.0.0 5.1.0.332 Xbim.ModelGeometry.Scene 5.1.0.1 5.1.430.0 Xbim.Presentation 5.1.0.0 5.1.0.0 Xbim.Tessellator 5.1.0.0 5.1.324.0

Steps (or code) to reproduce the issue:

Load the provided model in XbimXplorer 4 and 5, it appears different in 5, more wrong: Works 'fine' in 4: afbeelding

Definitely wrong in 5: afbeelding

Minimal file to reproduce the issue:

model.ifc.stripped.zip

Expected behavior:

I expected the wall to work at least as well as in the older versions.

Additional Details

I tried playing a bit with .ModelFactors.PrecisionBoolean but it seemed to make no difference.