xBimTeam / XbimGeometry

XbimGeometry contains the CLR interop libraries and the c++ engine used to compute the 3D geometry of models.
https://xbimteam.github.io/
Other
260 stars 131 forks source link

Some IfcProducts are duplicated in result IFC-file #397

Closed GVladislavG closed 1 year ago

GVladislavG commented 2 years ago

Hi, xBim team!

I got such problem lately. Resulting IFC-file has some elements twice. BimVision shows this message. But, if I get elements from model var myList = model.Instances.OfType<IIfcBuildingElementProxy>().ToList(); there are no duplicating elements in myList. If I search duplicating elements in IFC-file manualy, thre are also no duplicating elements. What's the problem and how can I fix it? IFC-file is in attached archive. test.zip

Thank you!

andyward commented 2 years ago

What's the error message you see in BIM Vision? What is the exact problem you're seeing? Is this a Geometry issue?

It's very hard to advise without a clearly defined problem.

GVladislavG commented 2 years ago

I see this message in BIM Vision. Ошибка In English: "The object is located in the file twice.

5017.Building Element Proxy. Оконный блок 12.12

The project may not be displayed correctly" I'm not really sure that it's Geometry problem.

You can replicate the problem by openning attached IFC in BimVision

andyward commented 2 years ago

xbim Toolkit has a built in validator of its own that can help you here:

See https://github.com/xBimTeam/XbimEssentials/blob/master/Tests/ValidationTests.cs

... here it is in action in XbimXplorer

image

There are various issues with the Spatial breakdown in that model. I suspect the issue BimVision is highlighting is that element 5017 (and others) are defined as being both part of the Site and a BuildingStorey. It should be one or the other.

Separately ensure the IfcBuildingStorey is related to the IfcBuilding

martin1cerny commented 1 year ago

Can we close this issue @GVladislavG?

GVladislavG commented 1 year ago

Yes, thanks!