xBimTeam / XbimGeometry

XbimGeometry contains the CLR interop libraries and the c++ engine used to compute the 3D geometry of models.
https://xbimteam.github.io/
Other
255 stars 128 forks source link

Simple file crashes XBim Xplorer #399

Open Moult opened 1 year ago

Moult commented 1 year ago

Crossposting from https://github.com/IfcOpenShell/IfcOpenShell/issues/2499 :)

Here's a simple model. In Revit, Blender, IFCJS, no issues at all.

in XBim Xplorer and ODA Open IFC Viewer, it shows a wall with no opening for the door, and any attempt to run the validator for both of those platforms causes a crash.

File here https://github.com/IfcOpenShell/IfcOpenShell/issues/2499

andyward commented 1 year ago

Thanks Dion we'll take a look

Moult commented 1 year ago

Part of the issue it seems is the XBim does not support booleans from tessellations.

jomijomi commented 1 year ago

@Moult I think you need to test this with a more recent version of xBIM Xplorer, because I have tested this file with multiple recent versions and I cannot see any problems (However, if I do test it with some older 4.0 assemblies the opening is missing. But this is a really old version...) /Mikael

Moult commented 1 year ago

Thanks @jomijomi how do I get the latest version of xBIM Xplorer? I downloaded the setup on this page: https://docs.xbim.net/downloads/xbimxplorer.html

When I run setup.exe I don't see an installer, it just launches presumably an existing version of xBIM which I already had installed. If I check the about page of xBIM I see this:

image

CBenghi commented 1 year ago

Hi Dion, I'll post an updated link here today, after I've updated the binaries. Claudio

On Tue, Oct 25, 2022, 01:23 Dion Moult @.***> wrote:

Thanks @jomijomi https://github.com/jomijomi how do I get the latest version of xBIM Xplorer? I downloaded the setup on this page: https://docs.xbim.net/downloads/xbimxplorer.html

When I run setup.exe I don't see an installer, it just launches presumably an existing version of xBIM which I already had installed. If I check the about page of xBIM I see this:

[image: image] https://user-images.githubusercontent.com/88302/197648359-fee8f0a6-c52b-492c-89ee-4d89fa203ad9.png

— Reply to this email directly, view it on GitHub https://github.com/xBimTeam/XbimGeometry/issues/399#issuecomment-1289772366, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJY7MN6TPHYRXQB3NMGG5LWE4K7HANCNFSM6AAAAAARE7OS7U . You are receiving this because you are subscribed to this thread.Message ID: @.***>

CBenghi commented 1 year ago

I can't find the time today to update the binaries, but the most updated xplorer is available at this address:

http://www.overarching.it/dload/XbimXplorer5/Setup.exe

It's self updating, it will autonomously check for future versions and silently update, expect a new version in a couple of days. Claudio

Moult commented 1 year ago

Thanks! I'll check it out and report back in a few days!

Moult commented 1 year ago

Just tested, the model is displayed correctly now, but it still crashes when I press the "Validate model" button in view>developer>validate.

andyward commented 1 year ago

Validator issue fixed by https://github.com/xBimTeam/XbimEssentials/commit/a99168f09248b0edc8aa2ba617451d972ff3c9eb

Will require Windows Explorer update